Refactor cost calculation to accept multiple size inputs #2152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedrosenbluth
changed the base branch from
master
to
feat/cost-contract-integration
reedrosenbluth
force-pushed
the
feat/compute-cost-multiple-inputs
branch
2 times, most recently
from
160b2e9 to
0b906b9
Compare
kantai
reviewed
Dec 11, 2020
kantai
reviewed
Dec 11, 2020
reedrosenbluth
force-pushed
the
feat/compute-cost-multiple-inputs
branch
from
6643167 to
398a500
Compare
jcnelson
reviewed
Dec 14, 2020
kantai
reviewed
Dec 14, 2020
jcnelson
reviewed
Dec 14, 2020
jcnelson
reviewed
Dec 14, 2020
Member
jcnelson
left a comment
jcnelson
left a comment
There was a problem hiding this comment.
I'm having a hard time seeing how the user-defined cost function's arguments are generated. Can you point me to where that happens?
Contributor
Author
@jcnelson Is this what you're looking for? |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
runtime_costfunction to take aVec<u64>instead of a singleu64, thus enabling Clarity cost functions to take multiple size input args.