Allow small test genesis file to be used in mocknet mode #2190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zone117x
force-pushed
the
feat/2176-mocknet-chainstate
branch
from
f23dc96 to
39f4fb6
Compare
zone117x
changed the title
jcnelson
reviewed
Dec 17, 2020
| pub fn new(config: Config, boot_block_exec: Box<dyn FnOnce(&mut ClarityTx) -> ()>) -> Self { | ||
| let use_test_genesis_data = if config.burnchain.mode == "mocknet" { | ||
| // When running in mocknet mode allow the small test genesis chainstate data to be enabled. | ||
| if env::var("BLOCKSTACK_USE_TEST_GENESIS_CHAINSTATE") == Ok("1".to_string()) { |
Member
There was a problem hiding this comment.
Instead of making this an envar, could we add this as a config option?
Contributor
Author
There was a problem hiding this comment.
We could, although env vars are easier to deal with in the tooling than config files. How strongly do you prefer config file vs env var?
Contributor
There was a problem hiding this comment.
It would be nice for the competition to set this as a config option
Contributor
Author
There was a problem hiding this comment.
Are we okay with allowing both methods? Config and env var
Contributor
Author
zone117x
force-pushed
the
feat/2176-mocknet-chainstate
branch
from
b8f20b1 to
e51b3b0
Compare
jcnelson
approved these changes
Dec 18, 2020
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2176