Skip to content

Conversation

Jiloc
Copy link
Contributor

@Jiloc Jiloc commented Sep 17, 2025

Description

This may fix the strange behavior we see in #6497 (comment) where we have both clarity-serialization and clarity-types

Jiloc and others added 30 commits August 7, 2025 22:07
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
… into feat/add-contract-cost-limit-percentage-config
…it_percentage value to demonstrate its behaviour

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
… into feat/add-contract-cost-limit-percentage-config
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
…ccurate

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
… into feat/add-contract-cost-limit-percentage-config
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
… into feat/add-contract-cost-limit-percentage-config
… into feat/add-contract-cost-limit-percentage-config
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
…7-6387

refactor: BitcoinRegtestController RPC roll out (STEP 7)
fdefelici
fdefelici previously approved these changes Sep 17, 2025
fix: print correct address version in `stacks-inspect decode-tx`
chore: add `cargo clippy-stackslib` to ci
kantai
kantai previously approved these changes Sep 17, 2025
[Clarity-4] implement `current-contract`
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 68.40924% with 1408 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.38%. Comparing base (f61ea59) to head (87c4373).
⚠️ Report is 35 commits behind head on aac-client-breaking.

Files with missing lines Patch % Lines
stacks-node/src/tests/nakamoto_integrations.rs 0.00% 917 Missing ⚠️
...-node/src/burnchains/bitcoin_regtest_controller.rs 60.00% 100 Missing ⚠️
clarity/src/vm/functions/assets.rs 0.00% 69 Missing ⚠️
clarity/src/vm/database/clarity_db.rs 42.69% 51 Missing ⚠️
...c/vm/analysis/type_checker/v2_1/tests/contracts.rs 85.20% 50 Missing ⚠️
clarity/src/vm/functions/crypto.rs 53.06% 23 Missing ⚠️
...vm/analysis/type_checker/v2_1/natives/sequences.rs 55.55% 20 Missing ⚠️
clarity/src/vm/tests/mod.rs 35.71% 18 Missing ⚠️
clarity-types/src/types/signatures.rs 84.61% 16 Missing ⚠️
...m/analysis/type_checker/v2_05/natives/sequences.rs 54.28% 16 Missing ⚠️
... and 27 more

❌ Your project status has failed because the head coverage (71.38%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           aac-client-breaking    #6499      +/-   ##
=======================================================
+ Coverage                71.17%   71.38%   +0.21%     
=======================================================
  Files                      557      563       +6     
  Lines                   341798   345414    +3616     
=======================================================
+ Hits                    243258   246564    +3306     
- Misses                   98540    98850     +310     
Files with missing lines Coverage Δ
clarity-types/src/diagnostic.rs 83.33% <ø> (ø)
clarity-types/src/errors/ast.rs 52.85% <100.00%> (ø)
clarity-types/src/errors/cost.rs 0.00% <ø> (ø)
clarity-types/src/errors/lexer.rs 18.18% <ø> (ø)
clarity-types/src/errors/mod.rs 75.30% <100.00%> (ø)
clarity-types/src/execution_cost.rs 72.93% <ø> (ø)
clarity-types/src/lib.rs 100.00% <ø> (ø)
clarity-types/src/representations.rs 83.93% <ø> (ø)
clarity-types/src/tests/mod.rs 100.00% <ø> (ø)
clarity-types/src/tests/representations.rs 75.00% <ø> (ø)
... and 154 more

... and 243 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61ea59...87c4373. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kantai kantai added this pull request to the merge queue Sep 17, 2025
Merged via the queue into aac-client-breaking with commit 5029abf Sep 17, 2025
17 of 18 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants