Skip to content

Conversation

@hstove-stacks
Copy link

The CODEOWNERS file is great in concept, but it has a big downside of automatically adding a ton of people as reviewers to a PR. This is theoretically fine, but there is no way to filter Github notifications for PRs where you're explicitly tagged as a reviewer. Additionally, it means you're default "participating" in each PR, further hurting notification triage-ability.

@hstove-stacks hstove-stacks requested review from a team November 24, 2025 22:29
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wileyj
Copy link
Collaborator

wileyj commented Nov 24, 2025

The CODEOWNERS file is great in concept, but it has a big downside of automatically adding a ton of people as reviewers to a PR. This is theoretically fine, but there is no way to filter Github notifications for PRs where you're explicitly tagged as a reviewer. Additionally, it means you're default "participating" in each PR, further hurting notification triage-ability.

all fair points - it's definitely outlived it's usefulness. kill it

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.47%. Comparing base (77f1583) to head (59705dd).
⚠️ Report is 2 commits behind head on develop.

❌ Your project status has failed because the head coverage (75.47%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6714      +/-   ##
===========================================
- Coverage    75.65%   75.47%   -0.19%     
===========================================
  Files          577      577              
  Lines       357690   357690              
===========================================
- Hits        270624   269977     -647     
- Misses       87066    87713     +647     

see 79 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f1583...59705dd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hstove-stacks hstove-stacks added this pull request to the merge queue Nov 25, 2025
Merged via the queue into stacks-network:develop with commit 76936b5 Nov 25, 2025
301 of 312 checks passed
@hstove-stacks hstove-stacks deleted the fix/no-codeowners branch November 25, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants