Chore: fix flake in non_blocking_minority_configured_to_favour_...#7215
Open
aaronb-stacks wants to merge 2 commits into
Open
Chore: fix flake in non_blocking_minority_configured_to_favour_...#7215aaronb-stacks wants to merge 2 commits into
aaronb-stacks wants to merge 2 commits into
Conversation
…g_miner There was a race between the stale Pre-Miner-2-winning-sortition global state and the expected Miner-2-won-sortition-and-timed-out state. This change removes that race by clearing the observer.
Coverage Report for CI Build 26250451051Coverage decreased (-0.1%) to 85.585%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions6617 previously-covered lines in 113 files lost coverage.
Coverage Stats
💛 - Coveralls |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test failed 3x in a row for me on a PR recently, so I tried to dig into the flakiness a little bit.
There was a race between the stale Pre-Miner-2-winning-sortition global state and the expected Miner-2-won-sortition-and-timed-out state. This change removes that race by clearing the observer.