perf(database): avoid rewriting single SQL spaces

Only replace whitespace when a non-space whitespace character or repeated
spaces are present. Keep trimming unconditional and retain the existing
replacement semantics for formatted queries.

Bun 1.4.1 focused repeat medians: prepared SQL 344 ns to 171 ns, long single-
spaced SQL 6.44 us to 5.18 us, formatted SQL 369 ns to 374 ns, Unicode whitespace
379 ns to 377 ns. Developer laptop results; full query/log timings were mixed,
so this does not claim an HTTP throughput improvement.

Verified 340927 generated cases, 1823 tests, framework types, and lint.
Final HTTP validation returned 139250 successful requests with exactly 139250
persisted logs. Add mixed/Unicode whitespace cases and a multiline persisted
query assertion.

Author: chrisbbreuer

storage/framework/core/database/src/query-parser.ts

@@ -145,8 +145,11 @@ export function normalizeQuery(sql: string): string {
     // Replace boolean and NULL literals in one pass.
     normalizedSql = normalizedSql.replace(/\b(?:true|false|null)\b/gi, '?')
 
-    // Normalize whitespace
-    normalizedSql = normalizedSql.replace(/\s+/g, ' ').trim()
+    // Most generated SQL already uses single spaces. Skip rebuilding it unless
+    // another whitespace character or repeated spaces need normalization.
+    if (/[^\S ]| {2}/.test(normalizedSql))
+      normalizedSql = normalizedSql.replace(/\s+/g, ' ')
+    normalizedSql = normalizedSql.trim()
 
     return normalizedSql
   }

storage/framework/core/database/tests/fixtures/query-logger-dispatch.ts

@@ -106,7 +106,7 @@ try {
     await queryWithDiagnostics('query_logger_after_failed_store')
 
     const { logQuery } = await import('../../src/query-logger')
-    const literalQuery = "SELECT 42 AS total, 'Ada 123' AS name, TRUE AS active, NULL AS missing FROM query_logger_fixture"
+    const literalQuery = " \tSELECT  42 AS total,\n 'Ada 123' AS name, TRUE AS active, NULL AS missing FROM query_logger_fixture"
     await logQuery({ query: { sql: literalQuery }, queryDurationMillis: 1 })
     const normalized = await db.unsafe('SELECT normalized_query FROM query_logs WHERE query = ?', [literalQuery]).execute()
     if (normalized.length !== 1 || normalized[0]?.normalized_query !== 'SELECT ? AS total, ? AS name, ? AS active, ? AS missing FROM query_logger_fixture')

storage/framework/core/database/tests/query-normalization.test.ts

@@ -3,6 +3,13 @@ import { normalizeQuery, parseQuery } from '../src/query-parser'
 
 describe('query normalization', () => {
   it.each([
+    [' SELECT id FROM items ', 'SELECT id FROM items'],
+    ['  SELECT   id,  name FROM  items  ', 'SELECT id, name FROM items'],
+    [' \tSELECT\r\n id,\vname\fFROM items\t WHERE id = 1 ', 'SELECT id, name FROM items WHERE id = ?'],
+    ['SELECT \t id \u00A0 FROM\u2003items', 'SELECT id FROM items'],
+    ['\uFEFFSELECT\u00A0id\u2028FROM\u2029items\u3000', 'SELECT id FROM items'],
+    [' \u0085SELECT\u180Eid\u200BFROM\u2060items ', '\u0085SELECT\u180Eid\u200BFROM\u2060items'],
+    [' \t\r\n\v\f\u00A0\u1680\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u2028\u2029\u202F\u205F\u3000\uFEFF', ''],
     ["SELECT '123'456, \"789\"10, a'12'34, _\"56\"78", 'SELECT ??, ??, a??, _??'],
     ["SELECT '12'x34, \"56\"_78, a12'34', _56\"78\"", 'SELECT ?x34, ?_78, a12?, _56?'],
     ["SELECT '12''34, \"56\"\"78", "SELECT ?'?, ?\"?"],