fix(bench): validate memory benchmark connection counts

Author: chrisbbreuer

bench/memory/run.test.ts

@@ -0,0 +1,20 @@
+import { describe, expect, it } from 'bun:test'
+import { parseArgs } from './run'
+
+describe('memory benchmark counts', () => {
+  it.each(['--connections', '-c', '--runs'])('requires a positive safe integer for %s', (flag) => {
+    for (const value of ['9007199254740992', '1.5', '0', '-1', 'Infinity', 'NaN', ''])
+      expect(() => parseArgs([flag, value]), `${flag} ${value}`).toThrow()
+  })
+
+  it('preserves defaults and accepts fractional timing windows and rates', () => {
+    expect(parseArgs([])).toMatchObject({ connections: 64, runs: 1, loadSeconds: 60, idleSeconds: 180 })
+    expect(parseArgs(['-c', '2', '--runs', '3', '--load', '0.5', '--idle', '0.75', '--interval', '10.5', '--settle', '0.25', '--rate', '100.5'])).toMatchObject({
+      connections: 2, runs: 3, loadSeconds: 0.5, idleSeconds: 0.75, sampleIntervalMs: 10.5, settleSeconds: 0.25, requestRate: 100.5,
+    })
+  })
+
+  it('still caps the settling window at the idle duration', () => {
+    expect(parseArgs(['--idle', '0.5', '--settle', '2']).settleSeconds).toBe(0.5)
+  })
+})

bench/memory/run.ts

@@ -51,11 +51,11 @@ function positiveNumber(flag: string, value: string): number {
 
 function positiveInteger(flag: string, value: string): number {
   const parsed = positiveNumber(flag, value)
-  if (!Number.isInteger(parsed)) throw new Error(`${flag} must be an integer`)
+  if (!Number.isSafeInteger(parsed)) throw new Error(`${flag} must be a safe integer`)
   return parsed
 }
 
-function parseArgs(argv: string[]): Options {
+export function parseArgs(argv: string[]): Options {
   const options: Options = {
     targets: BUN_141_API_PROFILE.map(target => target.targetId),
     scenario: 'static-json',
@@ -78,7 +78,7 @@ function parseArgs(argv: string[]): Options {
       case '--targets': options.targets = next().split(','); break
       case '--scenario': options.scenario = next(); break
       case '--driver': options.driver = next(); break
-      case '--connections': case '-c': options.connections = positiveNumber(flag, next()); break
+      case '--connections': case '-c': options.connections = positiveInteger(flag, next()); break
       case '--load': options.loadSeconds = positiveNumber(flag, next()); break
       case '--idle': options.idleSeconds = positiveNumber(flag, next()); break
       case '--interval': options.sampleIntervalMs = positiveNumber(flag, next()); break
@@ -103,13 +103,13 @@ const HELP = `bun bench/memory/run.ts [flags]
   --targets      comma-separated target ids (${TARGETS.map(target => target.id).join(', ')})
   --scenario     routing scenario to load (default static-json)
   --driver       oha | bombardier | autocannon | builtin
-  --connections  concurrent connections (default 64)
+  --connections  concurrent connections, positive integer (default 64)
   --rate         override the profile's fixed requests per second for every target
   --load         sustained-load seconds (default 60)
   --idle         quiet seconds after load (default 180)
   --interval     RSS sample interval in milliseconds (default 100)
   --settle       final idle window used for the median (default 10)
-  --runs         fresh-process repeats per target (default 1)
+  --runs         positive integer fresh-process repeats per target (default 1)
   --output       explicit output directory (default results/<timestamp>)`
 
 interface SelectedTarget extends MemoryProfileTarget {
@@ -313,4 +313,5 @@ async function main(): Promise<void> {
   console.log(report)
 }
 
-await main()
+if (import.meta.main)
+  await main()