Fix scale titles for index-provided scales#113
Merged
cbassuarez merged 2 commits intomainfrom Jan 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
scalaPathor place tenney manifests undertenney/ortenney/scale-builder.json, which should be used to compute a sensible title when the indextitlematches the pack title.Description
scalaPathtoCommunityIndexScaleand decodescalesfrom index entries so index-provided scales are recognized (CommunityPacksModels.swift).makeIndexScaleInfos(entry:indexScales:),resolveScaleTitle(...), and a synthesize overload to build pack JSON with per-scaleid/title/pathfor index-driven packs, and wire the index-driven flow intoCommunityPacksStorewhenindex.schemaVersion >= 2(CommunityPacksStore.swift).deriveScaleID(from:)and compute resolved fetch paths withresolvedScalePath(...), and use these when fetching and decoding scale payloads so titles reflect scala/tenney path components where appropriate.supportedSchemaVersionsand useassumedSchemaVersionaccordingly, and normalize cached decode labels to use resolved paths.Testing
Codex Task