fix(apply): share path containment with diff formatters#112
Conversation
Extract project-root guards so buildDiffJson cannot read outside the tree via traversal paths; apply and diff-json now use the same containment helpers.
🦋 Changeset detectedLatest commit: 96c3198 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
path-containment.tswith sharedisWithinProjectRoot/canonicalizeProjectFilePathhelpers.buildDiffJsonto skip rows whosefile_pathescapesprojectRoot(read-side leak).apply-engineto use the same helpers (behavior unchanged).Test plan
bun test src/application/output-formatters.test.ts src/application/apply-engine.test.tsbun run typecheck