feat(substrate): type_heritage table and recipe rewire#142
Conversation
Documents the substrate path to replace signature parsing in type-ancestors and type-descendants; links from roadmap and agent-surface related plans.
🦋 Changeset detectedLatest commit: b540202 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reached
More reviews will be available in 27 minutes and 18 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (41)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add AST-backed type_heritage extraction, import-aware resolve pass, and rewire type-ancestors/type-descendants to JOIN substrate rows. Schema bump 34→35; heritage-qualified fixture; goldens refreshed.
SutuSebastian
changed the title
* fix(heritage): address PR #142 review findings (cycle 1) Class superClass generics, type-alias resolve, incremental scope expansion, module-level symbol preference, complex extends fallback, recipe dedupe; heritage-resolver tests + new recipe goldens; doc/glossary updates. * fix(heritage): address review cycle 2 (expression bases, SQL dedupe) Skip resolve for (expression) heritage markers; align type-descendants homonym dedupe with ancestors via scope_local_id ordering; add scoped re-resolve test. * docs: close type-heritage-substrate plan (review cycle 3) Delete shipped plan per docs-governance; prune roadmap and agent-surface cross-refs; document (expression) heritage rows in recipe help. * fix(heritage): review cycle 4 (default import, re-export, SQL) Resolve default-import bases; expand incremental scope for re-export barrel importers; homonym dedupe on ancestor start symbols; align type kind filters; doc/changeset parity updates. * test(heritage): review cycle 5 (persist + incremental e2e) Add persistTypeHeritageResolution unit test and run-index incremental test proving scoped heritage re-resolve updates DB rows. * docs(recipes): note type kind filter on type-descendants (cycle 6)
1 participant
Summary
type_heritagesubstrate table (schema v35): AST-backed extends/implements extraction, import-aware resolve pass, and stats/perf wiring in the index engine.type-ancestors/type-descendantsrecipes to JOINtype_heritage(drops signature-parsing fragment).docs/plans/type-heritage-substrate.md(marked shipped) and roadmap/delivery tracker updates.Follow-up to merged #141 — replaces signature-parsing v1 with durable substrate.
Test plan
bun run typecheckbun run test:goldenbun test src/extractors/heritage.test.ts src/db.test.ts