Fix hardcoded projectile radius and terrain physics panic#89
Merged
Conversation
Add configurable `radius` field to `Projectile` struct (default 0.5) so collision detection uses per-projectile radius instead of a hardcoded value. Replace panic in terrain physics test with log::warn + continue for graceful handling of unexpected collider types. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying euca-engine with
|
| Latest commit: |
2a7998c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://77fe7c79.euca-engine.pages.dev |
| Branch Preview URL: | https://worktree-agent-a431c8da.euca-engine.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
radius: f32field toProjectilestruct (default 0.5) so projectile collision detection uses per-instance radius instead of a hardcoded constantpanic!("Expected AABB collider")in terrain physics test withlog::warn!+continuefor graceful handling of unexpected collider typesTest plan
cargo test --workspace-- all tests passcargo build --workspace-- clean buildcargo clippy --workspace-- no warningscargo fmt --all --check-- formatting verified🤖 Generated with Claude Code