Skip to content

Conversation

@TehreemNisa
Copy link
Contributor

@TehreemNisa TehreemNisa commented Dec 9, 2025

helm lint is always client side , we can update the helm values to ignore ciMode in code

@TehreemNisa TehreemNisa changed the title update helm dry run to server side , so it can find VPA when required fix: update helm dry run to server side , so it can find VPA when required Dec 9, 2025
@aslafy-z
Copy link
Collaborator

aslafy-z commented Dec 9, 2025

Hello,
The error is still there, but shadowed:

level=INFO msg="funcMap fail" message="There is no VerticalPodAutoscaler resource definition in the target cluster!"

@TehreemNisa
Copy link
Contributor Author

Hello, The error is still there, but shadowed:

level=INFO msg="funcMap fail" message="There is no VerticalPodAutoscaler resource definition in the target cluster!"

helm lint is always client side , but u can see dry-run succeeds now as i confirmed on the action-runners cluster VPA is installed and dry-run=server runs it on the parent cluster

image

@MuneebAijaz
Copy link
Contributor

https://github.com/stakater/application/actions/runs/19540652867/job/55945764463 helm lint always had issues, because of helm lint not having the cluster context as @TehreemNisa mentioned. You can see in the older passing actions where VPA tests pass but helm lint logs the issue.

@aslafy-z
Copy link
Collaborator

aslafy-z commented Dec 9, 2025

My bad, it works as expected! Thank you!

@aslafy-z aslafy-z changed the title fix: update helm dry run to server side , so it can find VPA when required ci: set helm dry run to server side so it find vpa Dec 9, 2025
@aslafy-z aslafy-z merged commit b5aa568 into main Dec 9, 2025
9 of 10 checks passed
@aslafy-z aslafy-z deleted the update-dry-run branch December 9, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants