fix: add instructions for all AI agents #6
Conversation
📝 WalkthroughWalkthroughUpdated MoonPay skill documentation: replaced Claude-specific wording with “your AI agent,” split Changes
Sequence Diagram(s)(Skipped — documentation-only changes; no new multi-component control flow to visualize.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md`:
- Around line 44-46: The README.md has fenced code blocks without language
identifiers causing MD040 lint failures; update the affected fences (the blocks
containing "Set up the yield-agentkit-moonpay skill") to include a language
identifier (e.g., change ``` to ```text) so markdownlint passes (apply the same
fix for the other occurrence noted around lines 155-157).
- Around line 42-43: The README's generic call-to-action "Open your AI Agent and
say:" conflicts with the requirements table that mandates "Claude Code";
reconcile them by making the setup wording and the requirements consistent:
either change the heading text "Open your AI Agent and say:" to explicitly
reference Claude (e.g., "Open your Claude Code agent and say:") or broaden the
requirements table (replace "Claude Code" with a generic agent entry and list
supported agents) so both the heading and the requirements convey the same agent
expectation; update the string "Open your AI Agent" and the table cell
containing "Claude Code" accordingly.
In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/references/key-rules.md`:
- Around line 30-31: Update Rule 7 to reflect the MoonPay signing flow: instead
of saying to pass the complete unsignedTransaction unchanged, state that for
MoonPay the unsignedTransaction must be serialized to base64 RLP (excluding the
from field during serialization) before calling the transaction_sign tool;
reference the transaction_sign flow in references/moonpay-tools.md and mention
the unsignedTransaction symbol so it's clear which object needs serialization.
In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/references/setup.md`:
- Around line 18-23: The non-Claude branch is too vague; update the instructions
so users explicitly register the MCP in their agent/IDE MCP settings: instruct
them to add MCP name "yield-agentkit", MCP URL "https://mcp.yield.xyz/mcp", and
set Transport to "HTTP", then verify that "yield-agentkit" appears in the
connected MCP list in their agent/IDE before continuing; reference the MCP
identifiers "yield-agentkit" and the URL to ensure readers can locate the
correct entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 434934a3-14d9-49af-908a-3927f8b9f2b4
📒 Files selected for processing (5)
yield-agentkit-skills/skills/yield-agentkit-moonpay/README.mdyield-agentkit-skills/skills/yield-agentkit-moonpay/SKILL.mdyield-agentkit-skills/skills/yield-agentkit-moonpay/references/key-rules.mdyield-agentkit-skills/skills/yield-agentkit-moonpay/references/moonpay-tools.mdyield-agentkit-skills/skills/yield-agentkit-moonpay/references/setup.md
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md (1)
209-216:⚠️ Potential issue | 🟠 MajorClarify confirmation gating, not just hash receipt
Line 215 says to wait for “transaction hashes,” but this flow must wait for confirmation of each transaction before proceeding. Hash receipt alone can fail/reorg and violates the sequential safety rule used elsewhere in this skill docs.
Suggested doc fix
-6. Wait for the transaction hashes. +6. Wait for each transaction to be CONFIRMED before continuing.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md` around lines 209 - 216, The README step that currently says to "wait for transaction hashes" must be changed to require waiting for transaction confirmation before proceeding; update the sequence around wallet_list, yields_get, actions_enter, transaction_sign, transaction_send and yields_get_balances to explicitly state that after transaction_send the agent should poll or await confirmation (finalized/confirmed status on the chain or via MoonPay's confirmation API) for each transaction sequentially before moving to the next step, ensuring confirmation gating not just hash receipt to maintain sequential safety.
🧹 Nitpick comments (1)
yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md (1)
149-152: Make local test command agent-agnosticLine 150 hardcodes
claude mcp list, while the doc is otherwise framed for generic AI agents. Consider adding a neutral primary instruction with Claude as an example to avoid mixed expectations.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md` around lines 149 - 152, The README currently hardcodes the test command "claude mcp list"; change this to a neutral, agent-agnostic primary instruction (e.g., "agent mcp list") and keep Claude as an example by showing "e.g., claude mcp list" or similar. Update the example block in README.md so the main command is generic and include the Claude variant as an illustrative example to avoid mixed expectations.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md`:
- Around line 33-34: The table rows in README.md violate markdownlint rule MD055
due to missing trailing pipe characters; update the two table lines containing
"Yield AgentKit MCP | https://mcp.yield.xyz/mcp" and "MoonPay MCP | mp" to
include a trailing "|" at the end of each line so the pipe-style table is
consistent and passes MD055.
---
Outside diff comments:
In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md`:
- Around line 209-216: The README step that currently says to "wait for
transaction hashes" must be changed to require waiting for transaction
confirmation before proceeding; update the sequence around wallet_list,
yields_get, actions_enter, transaction_sign, transaction_send and
yields_get_balances to explicitly state that after transaction_send the agent
should poll or await confirmation (finalized/confirmed status on the chain or
via MoonPay's confirmation API) for each transaction sequentially before moving
to the next step, ensuring confirmation gating not just hash receipt to maintain
sequential safety.
---
Nitpick comments:
In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md`:
- Around line 149-152: The README currently hardcodes the test command "claude
mcp list"; change this to a neutral, agent-agnostic primary instruction (e.g.,
"agent mcp list") and keep Claude as an example by showing "e.g., claude mcp
list" or similar. Update the example block in README.md so the main command is
generic and include the Claude variant as an illustrative example to avoid mixed
expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0454a1f4-f3d7-4e92-9352-5452e2a3d49c
📒 Files selected for processing (3)
yield-agentkit-skills/skills/yield-agentkit-moonpay/README.mdyield-agentkit-skills/skills/yield-agentkit-moonpay/references/key-rules.mdyield-agentkit-skills/skills/yield-agentkit-moonpay/references/setup.md
🚧 Files skipped from review as they are similar to previous changes (2)
- yield-agentkit-skills/skills/yield-agentkit-moonpay/references/key-rules.md
- yield-agentkit-skills/skills/yield-agentkit-moonpay/references/setup.md
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md (2)
55-57:⚠️ Potential issue | 🟡 MinorAdd fence languages for MD040 compliance.
The prompt blocks still use unlabeled fences; use
textto keep docs CI clean.Suggested fix
-``` +```text Set up the yield-agentkit-moonpay skill...
-
+text
Set up the yield-agentkit-moonpay skillAlso applies to: 166-168
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md` around lines 55 - 57, The Markdown README has unlabeled code fences that trigger MD040; update the fence language for the prompt blocks to use "text" so they are labeled (e.g., replace ``` with ```text for the blocks containing "Set up the yield-agentkit-moonpay skill"); apply this change to both occurrences shown (the block around lines with "Set up the yield-agentkit-moonpay skill" and the second occurrence at the later block).
33-34:⚠️ Potential issue | 🟡 MinorAdd trailing pipes to satisfy MD055.
These table rows still miss trailing
|, so markdownlint will continue to fail.Suggested fix
-|Yield AgentKit MCP | https://mcp.yield.xyz/mcp -|MoonPay MCP | mp +| Yield AgentKit MCP | https://mcp.yield.xyz/mcp | +| MoonPay MCP | mp |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md` around lines 33 - 34, The two markdown table rows "Yield AgentKit MCP | https://mcp.yield.xyz/mcp" and "MoonPay MCP | mp" are missing their trailing pipe characters; update those rows in README.md to append a final pipe ("|") to each line so they become "Yield AgentKit MCP | https://mcp.yield.xyz/mcp |" and "MoonPay MCP | mp |" to satisfy MD055.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md`:
- Around line 233-235: The "transaction_sign" debug step is pointing to the
wrong helper command (`mp wallet list`) which only lists wallets/addresses;
update the README entry for the transaction_sign failure to instruct using the
real balance-check command (e.g., the CLI subcommand that shows token/native
balances for a specific wallet) and show the correct usage pattern (wallet
identifier + token or native balance) so troubleshooters verify the signing
wallet has sufficient funds; replace the `mp wallet list` reference in the
transaction_sign row with the correct balance-check command and a short example
of its required args.
---
Duplicate comments:
In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md`:
- Around line 55-57: The Markdown README has unlabeled code fences that trigger
MD040; update the fence language for the prompt blocks to use "text" so they are
labeled (e.g., replace ``` with ```text for the blocks containing "Set up the
yield-agentkit-moonpay skill"); apply this change to both occurrences shown (the
block around lines with "Set up the yield-agentkit-moonpay skill" and the second
occurrence at the later block).
- Around line 33-34: The two markdown table rows "Yield AgentKit MCP |
https://mcp.yield.xyz/mcp" and "MoonPay MCP | mp" are missing their trailing
pipe characters; update those rows in README.md to append a final pipe ("|") to
each line so they become "Yield AgentKit MCP | https://mcp.yield.xyz/mcp |" and
"MoonPay MCP | mp |" to satisfy MD055.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5d89c049-c41c-495d-8ba7-d90d77fd8f33
📒 Files selected for processing (1)
yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md
There was a problem hiding this comment.
♻️ Duplicate comments (4)
yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md (4)
166-168:⚠️ Potential issue | 🟡 MinorAdd language identifier to fenced code block.
This fenced code block is missing a language identifier, causing MD040 lint violations.
Proposed lint fix
-``` +```text Set up the yield-agentkit-moonpay skill</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.mdaround lines
166 - 168, The fenced code block containing the line "Set up the
yield-agentkit-moonpay skill" is missing a language identifier; update that
backtick-fenced block to include a language (e.g., add "text" as the info
string) so the block becomestext ...to satisfy MD040 lint rules and
make the block explicit in README.md.</details> --- `55-57`: _⚠️ Potential issue_ | _🟡 Minor_ **Add language identifier to fenced code block.** This fenced code block is missing a language identifier, causing MD040 lint violations. <details> <summary>Proposed lint fix</summary> ```diff -``` +```text Set up the yield-agentkit-moonpay skill ``` ``` </details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.mdaround lines
55 - 57, The fenced code block in README.md is missing a language identifier
which triggers MD040; update the block surrounding the line "Set up the
yield-agentkit-moonpay skill" to include a language identifier (e.g., use
text instead of), ensuring the fenced code opening tag is changed so the
linter no longer flags it.</details> --- `33-34`: _⚠️ Potential issue_ | _🟡 Minor_ **Fix table pipe style to satisfy MD055.** These table rows are still missing trailing `|` characters, causing markdownlint MD055 violations. <details> <summary>Suggested lint fix</summary> ```diff -|Yield AgentKit MCP | https://mcp.yield.xyz/mcp -|MoonPay MCP | mp +| Yield AgentKit MCP | https://mcp.yield.xyz/mcp | +| MoonPay MCP | mp | ``` </details> <details> <summary>🤖 Prompt for AI Agents</summary> ``` Verify each finding against the current code and only fix it if needed. In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md` around lines 33 - 34, The markdown table rows "Yield AgentKit MCP | https://mcp.yield.xyz/mcp" and "MoonPay MCP | mp" are missing trailing pipe characters causing MD055; update those rows in README.md to end with a trailing '|' so each row becomes "Yield AgentKit MCP | https://mcp.yield.xyz/mcp |" and "MoonPay MCP | mp |" to satisfy the table pipe style rule. ``` </details> --- `161-161`: _⚠️ Potential issue_ | _🟡 Minor_ **Remove platform-specific qualifier from comment.** The comment `(if using claude)` is inconsistent with the document's agent-agnostic approach. Either remove the qualifier entirely or rephrase generically. <details> <summary>Suggested fix</summary> ```diff -# Should show: yield-agentkit, moonpay (if using claude) +# Should show: yield-agentkit, moonpay ``` Or, if the command is platform-specific: ```diff -# Should show: yield-agentkit, moonpay (if using claude) +# Should show: yield-agentkit, moonpay (if your agent supports 'mcp list') ``` </details> <details> <summary>🤖 Prompt for AI Agents</summary> ``` Verify each finding against the current code and only fix it if needed. In `@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md` at line 161, Update the README comment line "# Should show: yield-agentkit, moonpay (if using claude)" to remove the platform-specific qualifier by either deleting " (if using claude)" or rephrasing it generically (e.g., " (if supported by the agent)") so the document remains agent-agnostic; locate the exact comment text in the README to make this edit. ``` </details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In@yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md:
- Around line 166-168: The fenced code block containing the line "Set up the
yield-agentkit-moonpay skill" is missing a language identifier; update that
backtick-fenced block to include a language (e.g., add "text" as the info
string) so the block becomestext ...to satisfy MD040 lint rules and
make the block explicit in README.md.- Around line 55-57: The fenced code block in README.md is missing a language
identifier which triggers MD040; update the block surrounding the line "Set up
the yield-agentkit-moonpay skill" to include a language identifier (e.g., use
text instead of), ensuring the fenced code opening tag is changed so the
linter no longer flags it.- Around line 33-34: The markdown table rows "Yield AgentKit MCP |
https://mcp.yield.xyz/mcp" and "MoonPay MCP | mp" are missing trailing pipe
characters causing MD055; update those rows in README.md to end with a trailing
'|' so each row becomes "Yield AgentKit MCP | https://mcp.yield.xyz/mcp |" and
"MoonPay MCP | mp |" to satisfy the table pipe style rule.- Line 161: Update the README comment line "# Should show: yield-agentkit,
moonpay (if using claude)" to remove the platform-specific qualifier by either
deleting " (if using claude)" or rephrasing it generically (e.g., " (if
supported by the agent)") so the document remains agent-agnostic; locate the
exact comment text in the README to make this edit.</details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `949c12e2-c726-4d2c-957c-2d0bdd4d3d49` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 8dbb83627cef56595051dfbe822f2d34d06ebd27 and e94386c35fa2475bee2c8b140f61b8518417f1c3. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `yield-agentkit-skills/skills/yield-agentkit-moonpay/README.md` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Summary by CodeRabbit