Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds new yield providers ('sommelier' and 'euler') to the API schema and introduces a new optional field 'pricePerShare' to validator objects. The changes also update example dates in documentation comments from 2023 to 2025.
- Adds 'sommelier' and 'euler' as new yield provider options
- Introduces optional 'pricePerShare' field to ValidatorDto interface
- Updates documentation examples to use current year dates
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yieldV2YieldsProviderId.ts | Adds 'sommelier' and 'euler' provider IDs |
| yieldProviders.ts | Adds 'sommelier' and 'euler' to yield providers enum |
| validatorDto.ts | Adds optional 'pricePerShare' string field |
| reportProjectGetDailyRevenuesParams.ts | Updates date examples from 2023 to 2025 |
| reportProjectGetDailyPerformanceParams.ts | Updates date examples from 2023 to 2025 |
| index.msw.ts | Adds mock data generation for new 'pricePerShare' field |
| package.json | Bumps version from 0.0.107 to 0.0.108 |
Philippoes
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Description of new functionality, feature, or content that has been added in this pull request.
Changed
Description of the modifications made to existing functionality, feature, or content in this pull request. This could include changes to code, CI, documentation, etc.