Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for two new blockchain networks - Plasma (an EVM network) and Sui - to the API hooks package. The changes include updating the network schema definitions and bumping the package version.
- Added
plasmato EVM networks list (as it's an EVM-compatible chain) - Added
suito non-EVM networks list (Sui is a non-EVM blockchain) - Updated both general and yield-specific network schemas
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/api-hooks/src/api/schemas/yieldV2YieldsNetwork.ts | Added plasma and sui to yield network schema |
| packages/api-hooks/src/api/schemas/networks.ts | Added plasma and sui to general networks schema |
| packages/api-hooks/src/api/schemas/evmNetworks.ts | Added plasma to EVM networks schema |
| packages/api-hooks/package.json | Bumped version from 0.0.111 to 0.0.112 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| viction: 'viction', | ||
| core: 'core', | ||
| sonic: 'sonic', | ||
| plasma: 'plasma', |
There was a problem hiding this comment.
The plasma network is added to evmNetworks.ts (EVM networks), but sui is not added here despite being added to the same position in networks.ts and yieldV2YieldsNetwork.ts. This is correct behavior since Sui is not an EVM-compatible blockchain. However, verify that plasma is indeed an EVM-compatible network. If Plasma refers to the Plasma blockchain that is not EVM-compatible, it should be removed from this file.
| plasma: 'plasma', |
This pull request updates the
@stakekit/api-hookspackage to version 0.0.112 and expands support for additional blockchain networks across multiple schema files. The main focus is on adding theplasmaandsuinetworks to the relevant network lists, ensuring broader compatibility and feature coverage.Network support expansion:
plasmato theEvmNetworksinevmNetworks.ts.plasmaandsuito theNetworksinnetworks.ts. [1] [2]plasmaandsuitoYieldV2YieldsNetworkinyieldV2YieldsNetwork.ts. [1] [2]Version bump:
package.json.