Skip to content

feat: refresh vault registry with Trust OAV allocatorVaults + WBNB patch#18

Merged
ajag408 merged 1 commit intomainfrom
feat/eng-1855-registry-refresh-trust-oavs
Mar 23, 2026
Merged

feat: refresh vault registry with Trust OAV allocatorVaults + WBNB patch#18
ajag408 merged 1 commit intomainfrom
feat/eng-1855-registry-refresh-trust-oavs

Conversation

@ajag408
Copy link
Contributor

@ajag408 ajag408 commented Mar 23, 2026

Summary by CodeRabbit

  • Chores
    • Version 1.2.4 released
  • Re-exported vault registry from /v1/shield/registry — now includes Trust's 5 OAV proxy addresses as allocatorVaults
  • Re-applied WBNB patch (isWethVault: true) for 12 BSC vaults — the monorepo endpoint doesn't include BSC WBNB in its WETH address set
  • Vault count increased from 1,468 → 1,516

Why

Shield cannot validate transactions routed through Trust's OAV proxy contracts because none of the 5 proxy addresses were registered as allocatorVaults in the vault registry. The ERC4626 validator uses allocatorVaults to create additional lookup entries in vaultInfoMap — without them, legitimate Trust OAV transactions are rejected.

Trust OAV Proxies Added

OAV Yield Protocol Proxy Address
binance-u-fu-0x007df53c...-4626-vault Venus Flux 0x5150b6c808ad8aba8242e427f612b10102ca77b8
binance-u-u-0x9a17fd5c...-4626-vault ListaDAO 0x1a89b7a36ec8993525aeeeabbe0f505e5b91fdb1
ethereum-usdc-gtusdcp-0x8c106ee...-4626-vault Morpho V2 0xd8b444ac665b0de3a9135ad7be1a45f88ac97b3c
ethereum-crvusd-scrvusd-0x065597...-4626-vault Curve Savings 0x3ef5a8e7ab66b21cb81fe688e26fe45ed8cfdc27
ethereum-crvusd-cvcrvusd-0x5ae28c...-4626-vault Curve Lending 0xeb9b1598183a2fb7975076c9d4f5d64e2dd44170

Files Changed

File Change
src/validators/evm/erc4626/vault-registry.json Re-exported from monorepo + WBNB patched
package.json Version bump 1.2.3 → 1.2.4

Test Results

  • 10 test suites, 5,630 tests — all passing
  • All 5 Trust OAV proxy addresses verified in allocatorVaults
  • All 12 BSC WBNB vaults verified with isWethVault: true
  • Registry integrity checks pass (lowercase addresses, sorted by yieldId, 42-char allocator addresses)

@ajag408
Copy link
Contributor Author

ajag408 commented Mar 23, 2026

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2026

📝 Walkthrough

Walkthrough

Updated the package version from 1.2.3 to 1.2.4 in package.json. No changes to dependencies, scripts, configuration, or any other files.

Changes

Cohort / File(s) Summary
Version Update
package.json
Bumped version field from 1.2.3 to 1.2.4.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A minor hop, a version leap,
From two-three now to two-point-four we creep,
One line adjusted, simple and clean,
The freshest release the package has seen! 📦

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The pull request title states 'feat: refresh vault registry with Trust OAV allocatorVaults + WBNB patch' but the actual change is only a package version bump from 1.2.3 to 1.2.4, with no modifications to vault registry files or allocator vaults. Update the title to accurately reflect the changeset, such as 'chore: bump package version to 1.2.4' or verify if the correct files were included in this pull request.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/eng-1855-registry-refresh-trust-oavs

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
package.json (1)

1-75: ⚠️ Potential issue | 🔴 Critical

Critical: vault-registry.json changes are missing from this review.

The PR objectives state that src/validators/evm/erc4626/vault-registry.json was re-exported and patched with Trust's 5 OAV proxy addresses and WBNB flags for 12 BSC vaults, but this file is not included in the files for review. The core feature implementation cannot be validated without reviewing the vault registry changes.

Please ensure the vault-registry.json file is included in the review context so the actual feature changes (OAV proxy addresses, WBNB patches, vault count increase from 1,468 to 1,516) can be properly validated.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` around lines 1 - 75, The vault-registry.json that you declared
for re-export/patching (src/validators/evm/erc4626/vault-registry.json) is
missing from this PR; add the actual JSON file to the commit so reviewers can
validate the OAV proxy addresses and WBNB flag patches and the vault-count
increase. Locate the file at src/validators/evm/erc4626/vault-registry.json,
commit the patched JSON that includes Trust’s 5 OAV proxy addresses and WBNB
flags for the 12 BSC vaults, and ensure the committed file matches the "files"
entry in package.json so the change is included in the review and release
artifacts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 3: The package.json version field is incorrect (shows "1.2.4") and must
be bumped to the intended minor release "1.3.0"; open package.json, locate the
"version" property and change its value from "1.2.4" to "1.3.0" so the manifest
matches the PR objectives and semantic versioning for the new Trust OAV
allocatorVaults feature.

---

Outside diff comments:
In `@package.json`:
- Around line 1-75: The vault-registry.json that you declared for
re-export/patching (src/validators/evm/erc4626/vault-registry.json) is missing
from this PR; add the actual JSON file to the commit so reviewers can validate
the OAV proxy addresses and WBNB flag patches and the vault-count increase.
Locate the file at src/validators/evm/erc4626/vault-registry.json, commit the
patched JSON that includes Trust’s 5 OAV proxy addresses and WBNB flags for the
12 BSC vaults, and ensure the committed file matches the "files" entry in
package.json so the change is included in the review and release artifacts.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7dc01a11-b8e3-4c2f-863c-90a1a20f9d02

📥 Commits

Reviewing files that changed from the base of the PR and between d706520 and d69234a.

📒 Files selected for processing (2)
  • package.json
  • src/validators/evm/erc4626/vault-registry.json

@ajag408 ajag408 merged commit e69634a into main Mar 23, 2026
8 checks passed
Copy link

@raiseerco raiseerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants