feat: enriched tx#384
Merged
petar-omni merged 1 commit intomainfrom Jun 3, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 3c2760a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enriches transaction metadata by exposing structuredTransaction and annotatedTransaction across the codebase and test fixtures, and adds feeConfigurations in relevant setup files; it also bumps the @stakekit/api-hooks dependency.
- Added
structuredTransactionandannotatedTransactiontoSKTxMeta, state machine meta, and test fixtures. - Introduced empty
feeConfigurationsarrays in staking and referral flow setups. - Bumped
@stakekit/api-hooksversion to0.0.102and added a changeset entry.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/widget/tests/use-cases/staking-flow/setup.ts | Added feeConfigurations, annotatedTransaction, structuredTransaction to test fixture |
| packages/widget/tests/use-cases/sk-wallet.test.tsx | Added structuredTransaction and annotatedTransaction to test data |
| packages/widget/tests/use-cases/referral-flow/setup.ts | Added feeConfigurations to referral flow setup |
| packages/widget/src/pages/steps/hooks/use-steps-machine.hook.ts | Included annotatedTransaction and structuredTransaction in machine actionMeta |
| packages/widget/src/domain/types/wallets/generic-wallet.ts | Extended SKTxMeta to pick structuredTransaction and annotatedTransaction from TransactionDto |
| packages/widget/package.json | Bumped @stakekit/api-hooks dependency to 0.0.102 |
| .changeset/social-pandas-wait.md | Added patch changeset for "feat: enriched tx" |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/widget/src/pages/steps/hooks/use-steps-machine.hook.ts:306
- Consider adding or updating unit tests for the state machine to assert that
annotatedTransactionandstructuredTransactionare correctly propagated inactionMetawhen dispatching actions.
annotatedTransaction:
petar-omni
force-pushed
the
feat/enriched-tx
branch
from
5f7209d to
3c2760a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes enriched transaction data (structuredTransaction and annotatedTransaction) throughout the widget by updating types, state machine propagation, and test fixtures.
- Extended
SKTxMetato include the new fields. - Updated the steps state machine to carry the enriched tx properties.
- Adjusted unit test setups and snapshots to initialize the new fields.
- Bumped
@stakekit/api-hooksto pull in the backend support.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/widget/tests/use-cases/staking-flow/setup.ts | Added feeConfigurations and initialized new tx fields in fixtures |
| packages/widget/tests/use-cases/sk-wallet.test.tsx | Populated structuredTransaction and annotatedTransaction in SK wallet tests |
| packages/widget/tests/use-cases/referral-flow/setup.ts | Added feeConfigurations in referral-flow test setup |
| packages/widget/src/pages/steps/hooks/use-steps-machine.hook.ts | Propagate annotatedTransaction and structuredTransaction from constructedTx |
| packages/widget/src/domain/types/wallets/generic-wallet.ts | Extended SKTxMeta type to pick the two new transaction fields |
| packages/widget/package.json | Bumped @stakekit/api-hooks to version 0.0.102 |
| .changeset/social-pandas-wait.md | Added changeset entry for feature |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Philippoes
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
structuredTransactionandannotatedTransactionin transaction metaChanged
Description of the modifications made to existing functionality, feature, or content in this pull request. This could include changes to code, CI, documentation, etc.