Implements #22 “Turn URL bar into omnibox”#42
Merged
stakes merged 1 commit intostakes:masterfrom Jun 21, 2015
jaanus:omnibox
Merged
Implements #22 “Turn URL bar into omnibox”#42stakes merged 1 commit intostakes:masterfrom jaanus:omnibox
stakes merged 1 commit intostakes:masterfrom
jaanus:omnibox
Conversation
stakes
pushed a commit
that referenced
this pull request
Jun 21, 2015
Implements #22 “Turn URL bar into omnibox”
stakes
added a commit
that referenced
this pull request
Jul 1, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Omnibox support to Frameless. There’s a few pieces.
New UI in settings
There’s new UI to configure your search engine. DuckDuckGo is default, Google is also supported. Since there’s now navigation in Settings, I contained Settings in a real navigation controller (the previous solution had just a navigation bar, but didn’t actually support navigation).
Search/URL detection
The actual UI for searching is simple. You enter stuff in the omnibox. If it looks like a URL, it’s treated as URL. If it looks like a search query, it’s treated as a query and run to the search engine that you’ve configured.
The “looks like URL” part is done with a few simple prefix and regex rules that seemed to be robust enough in my testing.
Search engines
I only implemented Google and DuckDuckGo initially. Adding other ones is trivial, just add them in
SearchEngine. Not sure how much we should invest into extra search engine features, like safesearch on/off, local versions etc. This can be added if needed.