Conversation
Signed-off-by: cyc60 <avsysoev60@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR ensures remote-signer voluntary exit signatures are actually validated by checking the return value of milagro_bls_binding.Verify and failing fast when verification does not pass.
Changes:
- Add an explicit
bls.Verify(...)result check for remote-signer exit signatures. - Raise an exception when exit signature verification fails.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR tightens validator voluntary-exit signing by validating that the remote signer’s returned BLS signature actually verifies against the expected signing root, and aligns the sw-utils dependency revision with the intended version.
Changes:
- Add a
bls.Verify(...)check for remote-signer voluntary exit signatures and raise on verification failure. - Bump
sw-utilsgit revision fromv0.12.9tov0.12.12.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/validators/keystores/remote.py |
Validates remote-signer exit signatures before returning them. |
pyproject.toml |
Updates sw-utils dependency revision to v0.12.12. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
No description provided.