Refactor startup checks into domain-specific modules#692
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors startup validation logic into command/domain-specific modules, moving the operator start startup checks into src/commands/start/ and meta-vault-specific startup checks into src/meta_vault/.
Changes:
- Moved operator
startup_checks()implementation fromsrc/common/startup_check.pyintosrc/commands/start/startup_check.py. - Extracted meta-vault startup checks from
src/commands/process_meta_vaults.pyintosrc/meta_vault/startup_check.py. - Renamed several previously-private common startup-check helpers (e.g.,
check_*) to be importable fromsrc.common.startup_check.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/meta_vault/startup_check.py |
New module encapsulating meta-vault-specific startup checks used by the meta-vault processing command. |
src/common/startup_check.py |
Removes the top-level operator startup_checks() and exposes several helper checks as public functions. |
src/commands/start/startup_check.py |
New module containing the operator start command’s startup check sequence. |
src/commands/start/base.py |
Updates the start command to import startup checks from the new command-specific module. |
src/commands/process_meta_vaults.py |
Uses the extracted meta-vault startup checks module and gates execution behind skip_startup_checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
evgeny-stakewise
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startup_checks()fromsrc/common/startup_check.pyintosrc/commands/start/startup_check.pysrc/commands/process_meta_vaults.pyintosrc/meta_vault/startup_check.pyTest plan
startcommand runs startup checks correctlyprocess-meta-vaultscommand runs startup checks correctly