Skip to content

Refactor startup checks into domain-specific modules#692

Merged
cyc60 merged 1 commit intomasterfrom
startup-checks-refactor
Mar 20, 2026
Merged

Refactor startup checks into domain-specific modules#692
cyc60 merged 1 commit intomasterfrom
startup-checks-refactor

Conversation

@cyc60
Copy link
Copy Markdown
Contributor

@cyc60 cyc60 commented Mar 20, 2026

Summary

  • Extract startup_checks() from src/common/startup_check.py into src/commands/start/startup_check.py
  • Extract meta vault startup checks from src/commands/process_meta_vaults.py into src/meta_vault/startup_check.py
  • Make previously private check functions public for reuse across modules

Test plan

  • Verify operator start command runs startup checks correctly
  • Verify process-meta-vaults command runs startup checks correctly

Copilot AI review requested due to automatic review settings March 20, 2026 13:17
@cyc60 cyc60 mentioned this pull request Mar 20, 2026
2 tasks
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors startup validation logic into command/domain-specific modules, moving the operator start startup checks into src/commands/start/ and meta-vault-specific startup checks into src/meta_vault/.

Changes:

  • Moved operator startup_checks() implementation from src/common/startup_check.py into src/commands/start/startup_check.py.
  • Extracted meta-vault startup checks from src/commands/process_meta_vaults.py into src/meta_vault/startup_check.py.
  • Renamed several previously-private common startup-check helpers (e.g., check_*) to be importable from src.common.startup_check.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/meta_vault/startup_check.py New module encapsulating meta-vault-specific startup checks used by the meta-vault processing command.
src/common/startup_check.py Removes the top-level operator startup_checks() and exposes several helper checks as public functions.
src/commands/start/startup_check.py New module containing the operator start command’s startup check sequence.
src/commands/start/base.py Updates the start command to import startup checks from the new command-specific module.
src/commands/process_meta_vaults.py Uses the extracted meta-vault startup checks module and gates execution behind skip_startup_checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/common/startup_check.py
Comment thread src/meta_vault/startup_check.py
Comment thread src/commands/process_meta_vaults.py
@cyc60 cyc60 merged commit 9b2803b into master Mar 20, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants