fix: add Drop to TaskManagerHandle to kill child processes on unexpec…#3
Merged
abdalla1912mohamed merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
…ted exit - Add Drop impl for TaskManagerHandle that sends on the broadcast shutdown channel, triggering TaskManager::run() to call shutdown_all_tasks() which kills every process group - Fix TaskManager::run() to also call shutdown_all_tasks() when the mpsc channel closes (all handles dropped without explicit shutdown), preventing orphaned child processes - Extract duplicate process kill logic into terminate_process_group() helper used by both cancel_task and shutdown_all_tasks - Give TaskManagerHandle a clone of the broadcast shutdown_tx (previously #[allow(dead_code)] and unused on TaskManager) - Add tests: handle drop triggers shutdown, handle drop kills child processes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ted exit