fix: skip shell script tests on Windows #504
Merged
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The daemon executor tests use Unix shell scripts (.sh files with #!/bin/sh shebang) which cannot run on Windows, causing CI failures with error: '%1 is not a valid Win32 application. (os error 193)' Added #[cfg(unix)] to: - All shell script execution tests (test_script_exit_*, test_timeout, etc.) - Helper function create_script() and its imports - test_missing_script (uses Unix path format) The test_check_result_methods test remains cross-platform as it only tests struct methods without executing scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Windows CI build failing with error:
The daemon executor tests use Unix shell scripts (
.shfiles with#!/bin/shshebang) which cannot execute on Windows.Failed job: https://github.com/stakpak/agent/actions/runs/21791278038/job/62870926643
Solution
Added
#[cfg(unix)]attribute to skip shell script tests on Windows:test_script_exit_0test_script_exit_1test_script_exit_2test_script_timeouttest_capture_stderrtest_missing_scripttest_large_outputcreate_script()helper function and related importsThe
test_check_result_methodstest remains cross-platform as it only tests struct methods without executing scripts.Testing
test_check_result_methodsruns)