fix(server): preserve tool results and reduce checkpoint churn#536
Merged
ahmedhesham6 merged 2 commits intoFeb 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two server-side issues observed in gateway/session runs:
Tool result linkage was lost in session storage conversion
tool_call_idwhen convertingLLMMessage::ToolResult -> ChatMessage.Checkpoint churn in short sessions
Also added a TODO in
session_actorto migrate checkpoint storage to nativeVec<stakai::Message>and remove adapter conversion.Why
Validation
cargo fmton touched filescargo clippy -p stakpak-server -p stakpak-shared --lib -- -D warningscargo test -p stakpak-shared tool_result -- --nocapturecargo test -p stakpak-server preserves_tool_result_tool_call_id_through_storage_adapter -- --nocapturecargo test -p stakpak-server session_actor::tests -- --nocapturecargo check -p stakpak