fix: normalize plugin version tags on download#679
Open
ahmedhesham6 wants to merge 1 commit intomainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Normalizes plugin version resolution so downloads/installations use a canonical v-prefixed version string, while still supporting backends that store artifacts/tags without the v prefix.
Changes:
- Canonicalize configured and “latest” versions into a
v-prefixed form for internal comparisons and selection. - Add a one-time retry that flips the
vprefix (v1.2.3↔1.2.3) when a download fails. - Harden version comparison to ignore whitespace and
V/vprefix differences; add unit tests for normalization and comparisons.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalize plugin version resolution so download/install uses a canonical version format and retries the alternate tag form when needed.
Related Issues
None.
Changes Made
v-prefixed formV/vprefix differencesTesting
cargo fmt --check -- cli/src/utils/plugins.rscargo clippy -p stakpak --all-targets -- -D warningscargo test -p stakpak -- --nocaptureBreaking Changes
None.