Skip to content

[Draft/Proposal] Add state to Custom JS#243

Closed
aparlato wants to merge 1 commit intomainfrom
fix-js
Closed

[Draft/Proposal] Add state to Custom JS#243
aparlato wants to merge 1 commit intomainfrom
fix-js

Conversation

@aparlato
Copy link
Collaborator

@aparlato aparlato commented Oct 9, 2025

Description

Adds state concept to checkboxes. Debating whether this is overly complex and if not, whether we should extend it to the dropdown options. Offhand my thinking is: dropdowns seem more like an or scenario whereas checkboxes are more of an and scenario so dropdowns shouldn't need state in this way.

Closes # (downstream)

Solves the problem of needing to track state for a given style. Let me know when you want to review and I can provide an example config since this functionality is fairly complicated. That said, we might be able to build state into the functions in the config, but I've had many failed attempts there.

QA steps

  • Ask @aparlato for a test config
  • See if the state behavior feels appropriate
    • Doesn't set styling on other maps when the same map is in two panels
    • Doesn't mix up checkboxes and actual state of the map
    • Resets everything on style change

Author checklist

Create the PR

  • Fill out PR template
  • Make sure you've added a CHANGELOG entry under "Unreleased"
  • Request a review
  • Make any requested changes and get approval

After approval

  • Merge any changes from main into your branch, resolve any conflicts
  • Squash & merge changes into main
  • Delete branch

@aparlato aparlato requested review from ebrelsford and removed request for ebrelsford October 9, 2025 00:40
@aparlato aparlato marked this pull request as draft October 9, 2025 00:40
@aparlato aparlato mentioned this pull request Oct 17, 2025
13 tasks
@aparlato
Copy link
Collaborator Author

Closing this as excessive for our use case and not widely applicable. Downstream solved by #245 instead.

@aparlato aparlato closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant