Conversation
Collaborator
Author
|
Closing this as excessive for our use case and not widely applicable. Downstream solved by #245 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds state concept to checkboxes. Debating whether this is overly complex and if not, whether we should extend it to the dropdown options. Offhand my thinking is: dropdowns seem more like an
orscenario whereas checkboxes are more of anandscenario so dropdowns shouldn't need state in this way.Closes # (downstream)
Solves the problem of needing to track state for a given style. Let me know when you want to review and I can provide an example config since this functionality is fairly complicated. That said, we might be able to build state into the functions in the config, but I've had many failed attempts there.
QA steps
Author checklist
Create the PR
After approval
maininto your branch, resolve any conflictsmain