Skip to content

Globe pitch#250

Merged
aparlato merged 4 commits intoprecompile-optionfrom
globe-pitch
Dec 1, 2025
Merged

Globe pitch#250
aparlato merged 4 commits intoprecompile-optionfrom
globe-pitch

Conversation

@aparlato
Copy link
Collaborator

@aparlato aparlato commented Nov 20, 2025

Description

@ebrelsford this is again for a downstream client so I'm merging to precompile-option until that all gets approved.

  • Adds option for maplibre projections
  • Changes max pitch for GL styles from 60 to 85 (Mapbox max, Maplibre can go further)

QA steps

  • Add style preset for Maplibre style with an option for projection set to globe
    {
        id: 'my-cool-map',
        name: 'My cool map',
        type: 'maplibre-gl',
        url: https://coolmap.com/style.json,
        projection: 'globe',
      },
    
  • Switch between styles with and without projection and between renderers (eg Mapbox), confirm no errors
  • Make sure Maplibre and Mapbox styles allow pitch up to 85

Author checklist

Create the PR

  • Fill out PR template
  • Make sure you've added a CHANGELOG entry under "Unreleased"
  • Request a review
  • Make any requested changes and get approval

After approval

  • Merge any changes from main into your branch, resolve any conflicts
  • Squash & merge changes into main
  • Delete branch

@aparlato aparlato requested a review from ebrelsford November 20, 2025 01:57
@aparlato
Copy link
Collaborator Author

aparlato commented Dec 1, 2025

I'm going to merge this into the precompile branch for now to simplify which commits I'm pulling downstream so we don't need to keep as many branches up to date here. We can review this retroactively.

@aparlato aparlato merged commit 8047061 into precompile-option Dec 1, 2025
@aparlato aparlato deleted the globe-pitch branch December 1, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant