Skip to content

Add test coverage for mcmc_areas_ridges_data, mcmc_parcoord_data, mcmc_trace_data#508

Merged
jgabry merged 6 commits intostan-dev:masterfrom
utkarshpawade:test/mcmc-data-functions-coverage
Mar 26, 2026
Merged

Add test coverage for mcmc_areas_ridges_data, mcmc_parcoord_data, mcmc_trace_data#508
jgabry merged 6 commits intostan-dev:masterfrom
utkarshpawade:test/mcmc-data-functions-coverage

Conversation

@utkarshpawade
Copy link
Contributor

Fixes #507

Summary

  • Add unit tests for mcmc_areas_ridges_data() (4 tests): output structure, delegation to mcmc_areas_data(), multi-parameter and single-parameter cases
  • Add unit tests for mcmc_parcoord_data() (5 tests): output structure, default divergent column, np argument, minimum 2-parameter error, regex_pars support
  • Add unit tests for mcmc_trace_data() (9 tests): output structure/dimensions, highlight, n_warmup, iter1, error conditions, multi-parameter support, value_rank correctness

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.67%. Comparing base (015be80) to head (72ec17e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          35       35           
  Lines        5903     5903           
=======================================
  Hits         5825     5825           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry
Copy link
Member

jgabry commented Mar 26, 2026

Thanks. I modified these a bit to focus on things not already tested elsewhere. Some of these were duplicating tests of implementation details already covered indirectly through the plotting tests. I also made a few of the tests more precise in their assertions.

@jgabry jgabry merged commit 471afa8 into stan-dev:master Mar 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test coverage for mcmc_areas_ridges_data, mcmc_parcoord_data, and mcmc_trace_data

3 participants