Unable to set init files with num_chains > 1

[rok-cesnovar]

Description:

With num_chains > 1, one would expect that if you set init=file.json, CmdStan would look for init=file_1.json, init=file_2.json, init=file_3.json, and so on.

It however errors with a weird error that .json is not supported. The culprit is this line:

cmdstan/src/cmdstan/command.hpp

Line 155 in 3a3ef24

if (file_ending != ".json" || file_ending != ".csv") {

(should be && not ||).

The other issue is that if those files are not found it segfaults.

Reported here

Current Version:

v2.28.1

[rok-cesnovar]

To clarify when does it segfault. Create file.json and no file_1.json, and call a model with init=file.json.