Skip to content

Fix: issue with GQ arg checks, const ref string passing#1206

Merged
WardBrian merged 3 commits intodevelopfrom
cleanup/const-ref-and-warnings
Sep 27, 2023
Merged

Fix: issue with GQ arg checks, const ref string passing#1206
WardBrian merged 3 commits intodevelopfrom
cleanup/const-ref-and-warnings

Conversation

@WardBrian
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

This fixes a couple issues which came up as warnings for me:

  • the argument checking for GQ had a mismatched if-else which lead to one of the conditionals never being checked
  • a few places we were passing std::strings by value where a const ref would work

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the cleanup

@WardBrian WardBrian merged commit a87a1de into develop Sep 27, 2023
@WardBrian WardBrian deleted the cleanup/const-ref-and-warnings branch September 27, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments