Skip to content

raise exception from parent exception#284

Merged
mitzimorris merged 1 commit intodevelopfrom
update_exception_handling
Aug 27, 2020
Merged

raise exception from parent exception#284
mitzimorris merged 1 commit intodevelopfrom
update_exception_handling

Conversation

@ahartikainen
Copy link
Copy Markdown
Contributor

@ahartikainen ahartikainen commented Aug 26, 2020

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Raise child exception using from exc syntax.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Ari Hartikainen

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #284 into develop will not change coverage.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #284   +/-   ##
========================================
  Coverage    76.07%   76.07%           
========================================
  Files            9        9           
  Lines         2194     2194           
========================================
  Hits          1669     1669           
  Misses         525      525           
Impacted Files Coverage Δ
cmdstanpy/utils.py 77.37% <66.66%> (ø)
cmdstanpy/cmdstan_args.py 90.78% <100.00%> (ø)
cmdstanpy/model.py 81.69% <100.00%> (ø)
cmdstanpy/stanfit.py 95.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8597f...6d09897. Read the comment docs.

Copy link
Copy Markdown
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - many thanks!

@mitzimorris mitzimorris merged commit baad6ce into develop Aug 27, 2020
@ahartikainen ahartikainen deleted the update_exception_handling branch February 5, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants