Change require_converged behavior

[WardBrian]

Submission Checklist

• Run unit tests
• Declare copyright holder and open-source license: see below

Summary

Resolves #347 as discussed in that issue

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

• Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)

[mitzimorris]

LGTM!

[codecov-commenter]

Codecov Report

Merging #424 (58c600f) into develop (ea0f3f2) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #424      +/-   ##
===========================================
- Coverage    77.31%   77.23%   -0.09%     
===========================================
  Files           27       27              
  Lines         8556     8565       +9     
===========================================
  Hits          6615     6615              
- Misses        1941     1950       +9     

Impacted Files	Coverage Δ
a/cmdstanpy/cmdstanpy/cmdstanpy/model.py	80.54% <0.00%> (-0.51%)	⬇️
cmdstanpy/cmdstanpy/model.py	79.45% <0.00%> (-0.49%)	⬇️
...runner/work/cmdstanpy/cmdstanpy/cmdstanpy/model.py	79.45% <0.00%> (-0.49%)	⬇️
cmdstanpy/cmdstanpy/compiler_opts.py	93.33% <0.00%> (-0.22%)	⬇️
a/cmdstanpy/cmdstanpy/cmdstanpy/compiler_opts.py	93.33% <0.00%> (-0.22%)	⬇️
...ork/cmdstanpy/cmdstanpy/cmdstanpy/compiler_opts.py	93.33% <0.00%> (-0.22%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0f3f2...58c600f. Read the comment docs.