Removed .png from .gitignore, make sure release adds all untracked fi…

[serban-nicusor-toptal]

• Remove *.png from .gitignore as there are .png files in the docs directory.
• Stop using git commit -m "" -a and instead use git add . to add all tracked/untracked files.
• Remove _sources and _modules from /docs

Submission Checklist

• Run unit tests
• Declare copyright holder and open-source license: see below

Summary

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

• Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)

[codecov-commenter]

Codecov Report

Merging #443 (9d4368c) into develop (65cfd9d) will decrease coverage by 0.44%.
The diff coverage is n/a.

❗ Current head 9d4368c differs from pull request most recent head 21fd2f8. Consider uploading reports for the commit 21fd2f8 to get more accurate results

@@             Coverage Diff             @@
##           develop     #443      +/-   ##
===========================================
- Coverage    77.12%   76.68%   -0.45%     
===========================================
  Files           27        9      -18     
  Lines         8634     2878    -5756     
===========================================
- Hits          6659     2207    -4452     
+ Misses        1975      671    -1304     

Impacted Files	Coverage Δ
a/cmdstanpy/cmdstanpy/cmdstanpy/model.py
a/cmdstanpy/cmdstanpy/cmdstanpy/install_cmdstan.py
...ork/cmdstanpy/cmdstanpy/cmdstanpy/compiler_opts.py
a/cmdstanpy/cmdstanpy/cmdstanpy/cmdstan_args.py
...work/cmdstanpy/cmdstanpy/cmdstanpy/cmdstan_args.py
...runner/work/cmdstanpy/cmdstanpy/cmdstanpy/utils.py
...ner/work/cmdstanpy/cmdstanpy/cmdstanpy/_version.py
...k/cmdstanpy/cmdstanpy/cmdstanpy/install_cmdstan.py
...tanpy/cmdstanpy/cmdstanpy/install_cxx_toolchain.py
a/cmdstanpy/cmdstanpy/cmdstanpy/utils.py
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e114d...21fd2f8. Read the comment docs.

[serban-nicusor-toptal]

Thank you @mitzimorris total life saver! me and @WardBrian were trying to figure it out

[WardBrian]

I think renaming _static will break things, we should revert that latest commit

[mitzimorris]

he's correct - the developer console was displaying the name with "_static" correctly - obscured by link underline. my bad.

[WardBrian]

I think this will work now. Any idea why readthedocs hasn't built yet?

[serban-nicusor-toptal]

sadly with RTD we hit into a limit, need to wait 15 mins to 60 mins

[WardBrian]

It looks like a few of the old builds are still sitting around spinning, can we can those somehow to speed it up? e.g. https://readthedocs.org/projects/cmdstanpy/builds/14497521/

Hopefully we will never have to push more than one thing to them again and avoid this issue

[serban-nicusor-toptal]

Sadly I don't think so, there isn't any option to speed up, cancel or rebuild. I just hope it isn't completely stuck

[WardBrian]

Supposedly it is supposed to get killed if it takes more than 15 minutes, but who knows about that. I'm sure it will shake out eventually, we may need to manually prod it at some point though, and then just avoid overloading it in the future

[WardBrian]

Oh, when you reverted you didn't rename the folder, just change the command in make. The docs are still broken then, until that gets renamed or it gets re-run

[serban-nicusor-toptal]

Ah you're right, I need to re-ran it anyway so it gets fixed by CI: https://github.com/stan-dev/cmdstanpy/actions/runs/1141099103

[WardBrian]

huzzah, it has been fixed: https://mc-stan.org/cmdstanpy/. RTD is still spinning, but we had that working before so I trust it will sort out.

Thanks for all the troubleshooting @serban-nicusor-toptal

[serban-nicusor-toptal]

Glad it's sorted out, thanks everyone for the action and help on this! Have a great day/evening

[mitzimorris]

OK, I'm a moron - the _modules are what contains the source code - all the source links are broken. damn.

[serban-nicusor-toptal]

No worries at all I'm still around. What about the other one, should it still be removed? Gonna open a pr in a minute

…

On Wed, Aug 18, 2021, 03:34 Mitzi Morris ***@***.***> wrote: OK, I'm a moron - the _modules are what contains the source code - all the source links are broken. damn. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#443 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALR77DECLPKCW5R2VSUPGPTT5MEZRANCNFSM5CKY47CA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[WardBrian]

I think it's safer to leave it

[WardBrian]

If you're gonna rebuild the docs again, can you add

copybutton_prompt_text = r">>> |\.\.\. |\$ |In \[\d*\]: | {2,5}\.\.\.: | {5,8}: "
copybutton_prompt_is_regexp = True

to conf.py? I meant to add this, it makes the copying behavior on code examples cleaner by removing things like In [10]: from the text to be copied

[mitzimorris]

No worries at all I'm still around. What about the other one, should it still be removed?

we need both _modules and _sources.

[serban-nicusor-toptal]

Kept both, can you please confirm it's working as expected?

[WardBrian]

It looks good to me