Conversation
This was
linked to
issues
Sep 1, 2021
Codecov Report
@@ Coverage Diff @@
## develop #449 +/- ##
===========================================
- Coverage 76.96% 76.15% -0.81%
===========================================
Files 27 27
Lines 8664 8760 +96
===========================================
+ Hits 6668 6671 +3
- Misses 1996 2089 +93
Continue to review full report at Codecov.
|
ahartikainen
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
This closes up a couple tiny issues (seconds in filenames, a show_versions command) and fixes our tests failing if cmdstan isn't installed in ~/.cmdstan[py]
sample(),generate_quantities()et al now accept atime_fmtstring which is passed toRunSetfor the time format of the csv files. It defaults to"%Y%m%d%H%M%S", which is the same as before but with seconds appended.Output of show_versions is based on what xarray does for it's method of the same name, but it is simpler than their use case. It looks like:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: