Skip to content

Clarify cmdstan installation issue#480

Merged
mitzimorris merged 1 commit intodevelopfrom
cmdstan-missing-message
Oct 21, 2021
Merged

Clarify cmdstan installation issue#480
mitzimorris merged 1 commit intodevelopfrom
cmdstan-missing-message

Conversation

@WardBrian
Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This closes #479

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian requested a review from mitzimorris October 21, 2021 16:22
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #480 (8835b05) into develop (da8a86c) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #480      +/-   ##
===========================================
+ Coverage    77.93%   77.96%   +0.03%     
===========================================
  Files           30       30              
  Lines         8991     8991              
===========================================
+ Hits          7007     7010       +3     
+ Misses        1984     1981       -3     
Impacted Files Coverage Δ
cmdstanpy/cmdstanpy/utils.py 70.48% <0.00%> (ø)
a/cmdstanpy/cmdstanpy/cmdstanpy/utils.py 74.35% <0.00%> (ø)
...runner/work/cmdstanpy/cmdstanpy/cmdstanpy/utils.py 71.06% <0.00%> (ø)
cmdstanpy/cmdstanpy/model.py 84.83% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8a86c...8835b05. Read the comment docs.

Copy link
Copy Markdown
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mitzimorris mitzimorris merged commit 7245892 into develop Oct 21, 2021
@WardBrian WardBrian deleted the cmdstan-missing-message branch October 21, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better error message for missing CmdStan

3 participants