Skip to content

Fix install entrypoints (fixes #499).#500

Merged
WardBrian merged 1 commit intostan-dev:developfrom
tillahoffmann:install_entrypoint
Nov 18, 2021
Merged

Fix install entrypoints (fixes #499).#500
WardBrian merged 1 commit intostan-dev:developfrom
tillahoffmann:install_entrypoint

Conversation

@tillahoffmann
Copy link
Copy Markdown
Contributor

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This PR fixes setup.py console script entrypoints as discussed in #499.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Imperial College London

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Comment thread .github/workflows/main.yml
@tillahoffmann tillahoffmann reopened this Nov 18, 2021
@tillahoffmann
Copy link
Copy Markdown
Contributor Author

Accidentally force-pushed an empty commit which requires an additional approval to run the tests. History should be clean now.

Comment thread .github/workflows/main.yml
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #500 (573f1c7) into develop (5b80eb8) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #500      +/-   ##
===========================================
- Coverage    78.88%   78.84%   -0.04%     
===========================================
  Files           30       30              
  Lines         9276     9288      +12     
===========================================
+ Hits          7317     7323       +6     
- Misses        1959     1965       +6     
Impacted Files Coverage Δ
cmdstanpy/cmdstanpy/install_cmdstan.py 32.93% <0.00%> (+0.13%) ⬆️
a/cmdstanpy/cmdstanpy/cmdstanpy/install_cmdstan.py 32.93% <0.00%> (+0.13%) ⬆️
...k/cmdstanpy/cmdstanpy/cmdstanpy/install_cmdstan.py 32.93% <0.00%> (+0.13%) ⬆️
...tanpy/cmdstanpy/cmdstanpy/install_cxx_toolchain.py 26.01% <0.00%> (+0.28%) ⬆️
cmdstanpy/cmdstanpy/install_cxx_toolchain.py 18.49% <0.00%> (+0.36%) ⬆️
...tanpy/cmdstanpy/cmdstanpy/install_cxx_toolchain.py 18.49% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5d234...573f1c7. Read the comment docs.

@WardBrian WardBrian linked an issue Nov 18, 2021 that may be closed by this pull request
@WardBrian WardBrian merged commit c7cd3b6 into stan-dev:develop Nov 18, 2021
@WardBrian
Copy link
Copy Markdown
Member

Thanks!

@tillahoffmann tillahoffmann deleted the install_entrypoint branch November 18, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in install_cmdstan from 0.9.77 to develop

3 participants