Skip to content

Update workflow to allow manual runs on different CmdStan versions#502

Merged
WardBrian merged 3 commits intodevelopfrom
manual-testing
Nov 22, 2021
Merged

Update workflow to allow manual runs on different CmdStan versions#502
WardBrian merged 3 commits intodevelopfrom
manual-testing

Conversation

@WardBrian
Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This edits our main workflow to allow you to run it manually and specify a cmdstan version. Hopefully it is useful for things like stan-dev/cmdstan#1061

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian changed the title Attempt to allow manual version specifications Update workflow to allow manual runs on different CmdStan versions Nov 22, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #502 (e04e217) into develop (5b80eb8) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #502      +/-   ##
===========================================
- Coverage    78.88%   78.81%   -0.07%     
===========================================
  Files           30       30              
  Lines         9276     9286      +10     
===========================================
+ Hits          7317     7319       +2     
- Misses        1959     1967       +8     
Impacted Files Coverage Δ
a/cmdstanpy/cmdstanpy/cmdstanpy/model.py 88.18% <0.00%> (-0.44%) ⬇️
a/cmdstanpy/cmdstanpy/cmdstanpy/utils.py 75.41% <0.00%> (-0.07%) ⬇️
cmdstanpy/cmdstanpy/install_cmdstan.py 32.93% <0.00%> (+0.13%) ⬆️
a/cmdstanpy/cmdstanpy/cmdstanpy/install_cmdstan.py 32.93% <0.00%> (+0.13%) ⬆️
...k/cmdstanpy/cmdstanpy/cmdstanpy/install_cmdstan.py 32.93% <0.00%> (+0.13%) ⬆️
...tanpy/cmdstanpy/cmdstanpy/install_cxx_toolchain.py 26.01% <0.00%> (+0.28%) ⬆️
cmdstanpy/cmdstanpy/install_cxx_toolchain.py 18.49% <0.00%> (+0.36%) ⬆️
...tanpy/cmdstanpy/cmdstanpy/install_cxx_toolchain.py 18.49% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeacdf8...e04e217. Read the comment docs.

Copy link
Copy Markdown
Contributor

@serban-nicusor-toptal serban-nicusor-toptal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point on this change?

Is there a way to manually run GH workflow? Locally/Cloud?

@WardBrian
Copy link
Copy Markdown
Member Author

WardBrian commented Nov 22, 2021

You will be able run this by going to the Actions tab on the repo (like how we currently run the Release action). The main motivation is to be able to run the cmdstanpy tests on CmdStan release candidates as part of the release testing cycle. I've also used https://github.com/nektos/act to run actions locally, but our tests are a bit heavy for that with the # of docker instances

@rok-cesnovar
Copy link
Copy Markdown
Member

Is there a way to manually run GH workflow?

Yeah, similar to how its done for release CmdStanPy:

image

@WardBrian WardBrian merged commit 68ae4e7 into develop Nov 22, 2021
@WardBrian WardBrian deleted the manual-testing branch November 22, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants