Skip to content

Serialize complex numbers to json#535

Merged
WardBrian merged 1 commit intodevelopfrom
serialize-complex
Feb 11, 2022
Merged

Serialize complex numbers to json#535
WardBrian merged 1 commit intodevelopfrom
serialize-complex

Conversation

@WardBrian
Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This changes write_stan_json to handle complex numbers (Python or Numpy) in the way cmdstan expects

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian requested a review from mitzimorris February 4, 2022 16:18
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #535 (5baaf65) into develop (5ed096e) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #535      +/-   ##
===========================================
+ Coverage    79.16%   79.20%   +0.04%     
===========================================
  Files           45       45              
  Lines         9453     9480      +27     
===========================================
+ Hits          7483     7509      +26     
- Misses        1970     1971       +1     
Impacted Files Coverage Δ
a/cmdstanpy/cmdstanpy/cmdstanpy/utils.py 75.81% <0.00%> (+0.16%) ⬆️
cmdstanpy/cmdstanpy/utils.py 72.67% <0.00%> (+0.20%) ⬆️
...runner/work/cmdstanpy/cmdstanpy/cmdstanpy/utils.py 72.67% <0.00%> (+0.20%) ⬆️
a/cmdstanpy/cmdstanpy/cmdstanpy/model.py 88.76% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed096e...5baaf65. Read the comment docs.

@WardBrian WardBrian mentioned this pull request Feb 7, 2022
@WardBrian
Copy link
Copy Markdown
Member Author

@mitzimorris are you able to give this PR a quick look as well?

Copy link
Copy Markdown
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@WardBrian WardBrian merged commit fe2014d into develop Feb 11, 2022
@WardBrian WardBrian deleted the serialize-complex branch February 11, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants