Add sig_figs option for log_prob.#692
Merged
WardBrian merged 3 commits intostan-dev:developfrom Sep 6, 2023
Merged
Conversation
WardBrian
requested changes
Sep 6, 2023
Member
WardBrian
left a comment
There was a problem hiding this comment.
Thanks, this being missing was definitely an oversight.
A couple (small) things:
Co-authored-by: Brian Ward <brianmward99@gmail.com>
Contributor
Author
|
Thanks for the speedy input. It looks like there's something up with the cached precompiled header, but I couldn't figure out the root cause. |
Member
Codecov Report
@@ Coverage Diff @@
## develop #692 +/- ##
===========================================
- Coverage 80.03% 79.90% -0.13%
===========================================
Files 72 48 -24
Lines 10962 7312 -3650
===========================================
- Hits 8773 5843 -2930
+ Misses 2189 1469 -720 see 26 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WardBrian
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Add
sig_figsoption to thelog_probmethod, e.g., for checking manual gradients to higher precision. I have added tests that compare with a literal string of the expected digits because estimating the number of digits from a float can be fiddly.Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Harvard University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: