Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=========================================
Coverage ? 92.49%
=========================================
Files ? 7
Lines ? 1186
Branches ? 0
=========================================
Hits ? 1097
Misses ? 89
Partials ? 0
Continue to review full report at Codecov.
|
|
This is ready for review. Codecov on appveyor seems to not be working, so I decided to comment it out until we sort out the reason. |
434b2ba to
5f8e59a
Compare
jgabry
left a comment
There was a problem hiding this comment.
Thanks, looks good! Just one addition requested.
|
Appveyor tests pass but for some reason the codecov tests fail. I am not sure why. |
|
I don't know why codecov is failing either, but this looks good. I'll merge it now. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 92.64% 92.34% -0.31%
==========================================
Files 7 7
Lines 1183 1188 +5
==========================================
+ Hits 1096 1097 +1
- Misses 87 91 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reverts #100 since the underlying cmdstan issue will be resolved for 2.22
Closes #109