Skip to content

materialize() method for forcing draws and diagnostics (and inits and profiles) into memory#1181

Merged
jgabry merged 3 commits intostan-dev:masterfrom
MansMeg:add-materialize-method
Apr 18, 2026
Merged

materialize() method for forcing draws and diagnostics (and inits and profiles) into memory#1181
jgabry merged 3 commits intostan-dev:masterfrom
MansMeg:add-materialize-method

Conversation

@MansMeg
Copy link
Copy Markdown
Contributor

@MansMeg MansMeg commented Apr 18, 2026

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Separate materialize() from save_object() according to the discussion in #1179.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Måns Magnusson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.10%. Comparing base (cb6d218) to head (1fac734).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
- Coverage   91.23%   91.10%   -0.14%     
==========================================
  Files          15       15              
  Lines        6070     6091      +21     
==========================================
+ Hits         5538     5549      +11     
- Misses        532      542      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MansMeg
Copy link
Copy Markdown
Contributor Author

MansMeg commented Apr 18, 2026

The failing test cannot be due to this PR. It seems to be a Windows issue in general.

Copy link
Copy Markdown
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah we're seeing those failing windows tests in other places too, I'm not sure why yet. But definitely unrelated to this PR.

@jgabry jgabry linked an issue Apr 18, 2026 that may be closed by this pull request
@jgabry jgabry merged commit a9fcfa7 into stan-dev:master Apr 18, 2026
12 of 14 checks passed
@jgabry jgabry changed the title add materialize() method materialize() method for forcing draws and diagnostics (and inits and profiles) into memory Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable fit$save_object also to serialise directly to R

3 participants