Skip to content

Don't call init functions an extra time to validate them#1195

Merged
jgabry merged 1 commit into
masterfrom
fix/init-function-extra-call
Jun 5, 2026
Merged

Don't call init functions an extra time to validate them#1195
jgabry merged 1 commit into
masterfrom
fix/init-function-extra-call

Conversation

@jgabry

@jgabry jgabry commented Jun 5, 2026

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

When inits were specified using a function we were calling the function an extra time to validate it before using it, but we can just validate it at the time we use it.

Also made a few tiny edits to init argument doc.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter

codecov-commenter commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.10%. Comparing base (595efe0) to head (e5c6c0c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1195   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files          15       15           
  Lines        6125     6125           
=======================================
  Hits         5580     5580           
  Misses        545      545           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry jgabry merged commit f5d8d83 into master Jun 5, 2026
14 checks passed
@jgabry jgabry deleted the fix/init-function-extra-call branch June 5, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants