Conversation
Member
|
Yeah ignoring std_out if refresh=0 makes sense to me. Looks like tests are failing, but otherwise this seems good to me. |
Member
Author
Yeah, I touched the existing show_messages arg. Internally we now use show_stderr_messages and show_stdout_messages in procs. show_stderr_messages is what show_messages did previously and show_stdout_messages is used for this fix. |
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 89.23% 89.24% +0.01%
==========================================
Files 12 12
Lines 2535 2538 +3
==========================================
+ Hits 2262 2265 +3
Misses 273 273
Continue to review full report at Codecov.
|
jgabry
approved these changes
Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
The newton optimization method does not respect the refresh arg. This PR ignores all stdout when refresh = 0, which seems logical to me as the only reason someone would use refresh = 0, is when they do not want any info printed.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar, Univ. of Ljubljana
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: