Add sig_figs argument#327
Merged
rok-cesnovar merged 5 commits intomasterfrom Oct 29, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 89.24% 89.24%
=======================================
Files 12 12
Lines 2538 2548 +10
=======================================
+ Hits 2265 2274 +9
- Misses 273 274 +1
Continue to review full report at Codecov.
|
jgabry
approved these changes
Oct 29, 2020
Member
jgabry
left a comment
There was a problem hiding this comment.
This looks good, thanks! Optionally, maybe add a brief comment in the doc that increasing sig_figs increases the memory required?
jgabry
approved these changes
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #313
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar, Uni. of Ljubljana
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: