Conversation
…rd output rely on being able to parse the values to numeric. If not, finish parsing inv. metric. Added tests.
Member
Author
|
Also ran the example from @maxmantei and with this patch, it runs for all iterations. |
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
==========================================
+ Coverage 88.34% 88.37% +0.02%
==========================================
Files 12 12
Lines 2720 2726 +6
==========================================
+ Hits 2403 2409 +6
Misses 317 317
Continue to review full report at Codecov.
|
jgabry
reviewed
Dec 11, 2020
jgabry
approved these changes
Dec 12, 2020
Member
|
Looks good! The tests are all starting again because I made an edit to the NEWS file but they were all passing so I'm going to go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #393
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: