Add check for inits named with square brackets#452
Merged
rok-cesnovar merged 4 commits intostan-dev:masterfrom Feb 17, 2021
mike-lawrence:check_init_format
Merged
Add check for inits named with square brackets#452rok-cesnovar merged 4 commits intostan-dev:masterfrom mike-lawrence:check_init_format
rok-cesnovar merged 4 commits intostan-dev:masterfrom
mike-lawrence:check_init_format
Conversation
Collaborator
Author
|
Ah shoot, silly mistakes in both code and in my procedure for checking the tests passed before submitting this PR. Corrected now. |
rok-cesnovar
approved these changes
Feb 17, 2021
Member
rok-cesnovar
left a comment
rok-cesnovar
left a comment
There was a problem hiding this comment.
Nice, one suggestion for the error text. But can also leave it and improve the text later.
| } | ||
|
|
||
| if (grepl("\\[",names(unlist(init)))) { | ||
| stop("'init' contains entries with parameter names that include square-brackets, which is not permitted. To supply inits for a multi-element parameter, create a single entry with the parameter's name in the init list and use c()/matrix()/etc to specify the values.", call. = FALSE) |
Member
There was a problem hiding this comment.
Suggested change
| stop("'init' contains entries with parameter names that include square-brackets, which is not permitted. To supply inits for a multi-element parameter, create a single entry with the parameter's name in the init list and use c()/matrix()/etc to specify the values.", call. = FALSE) | |
| stop("'init' contains entries with parameter names that include square-brackets, which is not permitted. To supply inits for a vector, matrix or array of parameters, create a single entry with the parameter's name in the init list and specify init values for the entire parameter container.", call. = FALSE) |
Member
|
Thanks for fixing this! Also, can you add an entry to the NEWS.md. |
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
- Coverage 93.17% 92.33% -0.84%
==========================================
Files 12 12
Lines 2871 2832 -39
==========================================
- Hits 2675 2615 -60
- Misses 196 217 +21
Continue to review full report at Codecov.
|
Member
|
Great! Will merge once tests pass again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #451 (& stan-dev/cmdstan#966)
Submission Checklist
Summary
Please describe the purpose of the pull request.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Michael A. Lawrence
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: