Skip to content

Fix use of tilde with cmdstanr_write_stan_file_dir#665

Merged
rok-cesnovar merged 4 commits intomasterfrom
fix-dir-tilde
Jul 8, 2022
Merged

Fix use of tilde with cmdstanr_write_stan_file_dir#665
rok-cesnovar merged 4 commits intomasterfrom
fix-dir-tilde

Conversation

@rok-cesnovar
Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

See https://discourse.mc-stan.org/t/problem-using-cmdstanr-write-stan-file-dir-with-brms/28117 for reasons
Essentially using ~ with the cmdstanr_write_stan_file_dir option did not work. This fixes that.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@rok-cesnovar
Copy link
Copy Markdown
Member Author

@sims1253 confirmed the fix works for the reported issue so I am going to merge once the tests pass.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 8, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (953fdd0) to head (414843b).
⚠️ Report is 902 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #665   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          12       12           
  Lines        3529     3530    +1     
=======================================
+ Hits         3168     3169    +1     
  Misses        361      361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rok-cesnovar rok-cesnovar merged commit 5fc41ea into master Jul 8, 2022
@rok-cesnovar rok-cesnovar deleted the fix-dir-tilde branch July 8, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants