Skip to content

Conversation

@mcol
Copy link
Member

@mcol mcol commented Jan 22, 2020

Submission Checklist

  • Builds locally
  • Declare copyright holder and open-source license: see below

Summary

This undoes some of my changes from #94, as log_falling/rising_factorial takes a real n, not int. Sorry about that!

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Marco Colombo

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

@bob-carpenter
Copy link
Member

This can be merged, but I don't know what the release restrictions are, so I'm not going to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants