Skip to content

Conversation

@WardBrian
Copy link
Member

@WardBrian WardBrian commented Oct 21, 2021

  • Remove cmdstan manual from the Jenkins pipeline
  • Make add_links.sh step optional in the Jenkins pipeline

Submission Checklist

  • Builds locally
  • New functions marked with `r since("VERSION")`
  • Declare copyright holder and open-source license: see below

Summary

This closes #421. I've manually redirected all the prior redirects which ended in -section etc to the current ones that don't. This should work even as the future versions change, with the downside being that it is really now two redirects for the affected pages.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian
Copy link
Member Author

@rok-cesnovar I'm not sure if this should be merged before or after the CI which rebuilds the doc

@rok-cesnovar
Copy link
Member

We dont really need to rebuild the doc for 2.28.1 right? Was anything added in the meantime?

@WardBrian
Copy link
Member Author

#418 was merged, which would be nice to have

@rok-cesnovar
Copy link
Member

Oh, then lets do that first, though I will select it to not add redirects again (it would duplicate them), but lets wait just in case. Will start that now.

Also thanks for this!!

@rok-cesnovar
Copy link
Member

@serban-nicusor-toptal can you kill the job running here: https://jenkins.mc-stan.org/blue/organizations/jenkins/BuildDocs/detail/BuildDocs/81/pipeline/

I did not specify the previous version, hoping that might skip adding links (the add_links.sh script). Is there another way to skip it?

@WardBrian
Copy link
Member Author

Will running with 2_27 as the prev. and then merging this not do what we want?

@rok-cesnovar
Copy link
Member

Based on my previous experience with this job it would duplicate the redirects.

@serban-nicusor-toptal
Copy link
Contributor

I think that might not work because of this array accessed by [1] as it expects to split that old version input.
If it's one-time only we can just run a job and take out what we don't need ( see Replay a job in Jenkins ), else I can make it as a parameter for the job in this PR.

@WardBrian
Copy link
Member Author

That jenkinsfile also still has a step to run make manual in the cmdstan repo - is that still needed? I think the cmdstan guide lives here now

@serban-nicusor-toptal
Copy link
Contributor

serban-nicusor-toptal commented Oct 21, 2021

Not needed anymore, I'll remove it in the morning. ( in this PR )

Can you please add to the PR Submission Checklist:

  • Remove cmdstan manual from the Jenkins pipeline
  • Make add_links.sh step optional in the Jenkins pipeline

Thanks!

@WardBrian
Copy link
Member Author

So if this is merged and docs are rebuilt without add_links are we good?

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkinsfile changes look good. Links fixes as well.

@rok-cesnovar
Copy link
Member

Merging then rebuiliding should be good now yes.

@rok-cesnovar rok-cesnovar merged commit d7b6fdf into master Oct 22, 2021
@rok-cesnovar rok-cesnovar deleted the redirect-patch branch October 22, 2021 13:36
@WardBrian
Copy link
Member Author

Seems like theres some error in the jenkinsfile?

@rok-cesnovar
Copy link
Member

Silly syntax error yeah. On it.

@serban-nicusor-toptal
Copy link
Contributor

Argh I forgot to put it in a script{} block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken links in SUG 2.27

3 participants