-
-
Notifications
You must be signed in to change notification settings - Fork 127
Manually fix redirects #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rok-cesnovar I'm not sure if this should be merged before or after the CI which rebuilds the doc |
|
We dont really need to rebuild the doc for 2.28.1 right? Was anything added in the meantime? |
|
#418 was merged, which would be nice to have |
|
Oh, then lets do that first, though I will select it to not add redirects again (it would duplicate them), but lets wait just in case. Will start that now. Also thanks for this!! |
|
@serban-nicusor-toptal can you kill the job running here: https://jenkins.mc-stan.org/blue/organizations/jenkins/BuildDocs/detail/BuildDocs/81/pipeline/ I did not specify the previous version, hoping that might skip adding links (the add_links.sh script). Is there another way to skip it? |
|
Will running with 2_27 as the prev. and then merging this not do what we want? |
|
Based on my previous experience with this job it would duplicate the redirects. |
|
I think that might not work because of this array accessed by [1] as it expects to split that old version input. |
|
That jenkinsfile also still has a step to run |
|
Not needed anymore, I'll remove it in the morning. ( in this PR ) Can you please add to the PR Submission Checklist:
Thanks! |
|
So if this is merged and docs are rebuilt without add_links are we good? |
rok-cesnovar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jenkinsfile changes look good. Links fixes as well.
|
Merging then rebuiliding should be good now yes. |
|
Seems like theres some error in the jenkinsfile? |
|
Silly syntax error yeah. On it. |
|
Argh I forgot to put it in a |
Submission Checklist
`r since("VERSION")`Summary
This closes #421. I've manually redirected all the prior redirects which ended in
-sectionetc to the current ones that don't. This should work even as the future versions change, with the downside being that it is really now two redirects for the affected pages.Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: