update 'LFO' and 'non-factorized' vignettes#148
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 27 27
Lines 2633 2633
=======================================
Hits 2509 2509
Misses 124 124 Continue to review full report at Codecov.
|
Member
|
The changes to the text look good, thanks! I didn't check that all the code runs yet. Did you try knitting them? If they knit fine for you then we can go ahead and merge. |
Contributor
Author
|
Thanks! I did knit the LFO vignette (which works) and didn't make any changes to the code of the non-factorized vignette, which should thus still run. |
Member
|
Ok great, thanks! |
jgabry
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the LFO and non-factorized vignettes according to the latest changes and improvements we made in the corresponding papers. @jgabry would you mind taking a look? Feel free to make additional changes. If you are happy with it, please feel free to merge.