Skip to content

Shortened ?loo_subsample title and slightly edited description#339

Merged
jgabry merged 3 commits intostan-dev:masterfrom
vinniott:shorten-loo-subsample-title
Mar 20, 2026
Merged

Shortened ?loo_subsample title and slightly edited description#339
jgabry merged 3 commits intostan-dev:masterfrom
vinniott:shorten-loo-subsample-title

Conversation

@vinniott
Copy link
Contributor

Fixes #338

Note that:

  • I only tested devtools::check(vignettes = F)
  • I slightly edited the description, too.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (d5e23dd) to head (1e13153).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          31       31           
  Lines        2992     2992           
=======================================
  Hits         2776     2776           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I agree about simplifying the title. I made one comment with a suggested change.

@@ -1,5 +1,7 @@
#' Efficient approximate leave-one-out cross-validation (LOO) using subsampling,
#' so that less costly and more approximate computation is made for all LOO-fold,
#' @title Efficient approximate LOO-CV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need @title if the text is in the first line of the roxygen comment block (it will automatically use @title for you).

Also, I think we should keep "using subsampling" in the title since that's what distinguishes loo_subsample, but I agree we should get rid of the rest of the long title and put that info in the description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vinniott vinniott requested a review from jgabry March 20, 2026 15:45
Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Merging the PR now

@jgabry jgabry merged commit 7eafeb8 into stan-dev:master Mar 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shorter ?loo_subsample title

3 participants